[MPlayer-dev-eng] Re: [PATCH] massive attack! mp_msg printf format warnings

[Dominik 'Rathann' Mierzejewski]

Hi,

On Wednesday, 17 September 2003, Alban Bedel wrote:
[...]
> I noticed smthg. When an argument is an off_t then you should ifdef for
> _LARGEFILE_SOURCE. So message like this one :
> 
> -    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %d [%d] %d  pre:%d  eof:%d  \n",
> +    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %lld [%lld] %lld  pre:%d  eof:%d  \n",
>  	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);
> 
> should become something like this (may be wrong too ;) 
> 
> -    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %d [%d] %d  pre:%d  eof:%d  \n",
> -	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);
> +#ifdef _LARGEFILE_SOURCE
> +    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %lld [%lld] %lld  pre:%d  eof:%d  \n",
> +	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);
> +#else
> +    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %d [%d] %d  pre:%d  eof:%d  \n",
> +	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);
> +#endif

No, actually I think you're right. I'll try post an updated patch tonight
or tomorrow. No other comments?

Oh, and BTW: should I care to release 1.0pre1 RPMs or should I go ahead
and release current CVS snapshot? Because I'm still sorting out some issues,
mainly faad - related, which have been fixed in CVS.

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"