[MPlayer-dev-eng] Re: [PATCH] massive attack! mp_msg printf format warnings

[Alban Bedel]

Hi Dominik 'Rathann' Mierzejewski,

on Sun, 14 Sep 2003 00:13:45 +0200 you wrote:

> Hello.
> Some time ago a patch was committed into CVS which enabled printf format
> checking for mp_msg calls. And so here's a patch that silences almost
> all warnings that came up. It applies cleanly against yesterday's CVS,
> too.
I noticed smthg. When an argument is an off_t then you should ifdef for
_LARGEFILE_SOURCE. So message like this one :

-    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %d [%d] %d  pre:%d  eof:%d  \n",
+    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %lld [%lld] %lld  pre:%d  eof:%d  \n",
 	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);

should become something like this (may be wrong too ;) 

-    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %d [%d] %d  pre:%d  eof:%d  \n",
-	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);
+#ifdef _LARGEFILE_SOURCE
+    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %lld [%lld] %lld  pre:%d  eof:%d  \n",
+	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);
+#else
+    mp_msg(MSGT_CACHE,MSGL_V,"CACHE_PRE_INIT: %d [%d] %d  pre:%d  eof:%d  \n",
+	s->min_filepos,s->read_filepos,s->max_filepos,min,s->eof);
+#endif

	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.