[MPlayer-dev-eng] [PATCH] 2d denoiser, second edition

[D Richard Felker III]

On Fri, Sep 12, 2003 at 02:41:47PM -0700, Corey Hickey wrote:
> ./configure --cc=gcc-2.95 && make  --  fails
> ./configure --cc=gcc-3.2 && make   --  succeeds
> ./configure --cc=gcc-3.3 && make   --  fails
> 
> For comparison, here's the output of gcc-2.95:
> gcc-2.95 -c -O4 -march=i686 -mcpu=i686 -pipe -ffast-math 
> -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE 
> -D_FILE_OFFSET_BITS=64 -I. -Inative -I.. -I../libmpdemux -I../loader 
> -D_GNU_SOURCE -o vf_hqdnsm.o vf_hqdnsm.c
> vf_hqdnsm.c: In function `scanMMX2':
> vf_hqdnsm.c:285: parse error before `['

Right, because this code is using gcc-3 extentions to the inline asm,
which are NOT acceptable!! gcc-3 runs at half the speed of 2.95, has
lots more bugs, and last I checked (3.1; this may no longer be true
with 3.3) it produced code that ran significantly slower (10% slower!)
on K6 than what 2.95 produced. With all the slowness, bugs, and
general headaches of gcc3, 2.95.3 should remain the preferred compiler
version for a LONG time to come, and gcc3-dependent code should not be
committed to mplayer cvs.

Rich