[MPlayer-dev-eng] [PATCH][Preversion]flac support

[Arpi]

Hi,

> Here is patch, which adds flac support into MPlayer.
> If nobidy objects I'll commit it in a week. (Currently it depends on 
> libFLAC, but I suppose I can
> integrate necessary parts of libFLAC into MPlayer)
> However, there are some problems (or misunderstanding of MPlayer 
> internal's):
> 1) Is it enough to return -1 in decode_audio to stop decoding of current 
> file? (It's written so, but is
>  doesn't always work)

it keeps reading (and decoding) the stream until eof is reached.

> 2) Can I set timing of current fragment not in demuxer?

not in g1
you can in g2

> 3) There is problem with flac-integrated-in-ogg. If I use dump_ogg from 
> G2, it sucessfully dumps
>   flac stream, but demux_ogg return eof afeter some first packets. Could 
> somebody help with this
>   problem?

probably requires some changes to demux_ogg
ogm is quite silly format, requires demuxer support for each codec type :(

> 4) With flac is possible to have bits-per-sample from 4 to 32. However 
> MPlayer (IIUC) allow bps to be
>    only 8, 16, or 32 bits per s. How should I deal with this? How should 
> I deal with this problem? (E.g. is
>    recoding in the codec acceptable?)

either add 4-to-any converter to libaf, or add conversion code to codec
the later is not nice, but allowed and already done in many of them
(it probably will not be allowed in g2, though)


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu