[MPlayer-dev-eng] RE: gmake fails if I use --language=de

[D Richard Felker III]

On Thu, Oct 30, 2003 at 02:44:57AM +0100, Diego Biurrun wrote:
> Arpi writes:
>  > > Attila Kinali writes:
>  > >  > On Wed, 29 Oct 2003 02:35:06 +0100
>  > >  > Diego Biurrun <diego at biurrun.de> wrote:
>  > >  > 
>  > >  > >  > #!/usr/bin/env bash is the solution
>  > >  > > 
>  > >  > > Attila, what kind of a difference is this supposed to make?
>  > >  > 
>  > >  > /usr/bin/env exists on every system i know, if you use env to
>  > >  > run a program it searches $PATH for it, ie, you can write a bash
>  > >  > script that runs also on a *BSD or a solarsi where bash 
>  > >  > might be under /usr/local/ w/o the need of changing the #! line
>  > >  > This trick was/is used by a lot of tcl scripts where tcl can be
>  > >  > installed anywhere.
>  > > 
>  > > Sounds reasonable.  Anybody _against_ changing the first line of
>  > > help/help-diff.sh?
>  > 
>  > yes
>  > imho that script doesnt depend on bash at all, so change it to /bin/sh
>  > if it's false (it depends on bash) then fix teh script...
>  > its a very important script (is run by all non-english compile)
>  > so it shouldnt depend on it
> 
> The problem is the use of 'read -r'.
> 
> Just checked again with ash and lo and behold, it works fine here
> under Debian (ash 0.3.8-37).  Hmm, I had assumed it would always fail
> with ash since it does under Cygwin (ash as /bin/sh).  It also breaks
> on Solaris and HP-UX.  None of the above is an important platform,
> though, so I agree they do not warrant the change.  What about the
> BSDs?

Looked at my rewrite in sed script anymore? :)

Rich