[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Diego Biurrun]

Michael Niedermayer writes:
 > On Tuesday 28 October 2003 16:00, Diego Biurrun wrote:
 > > Michael Niedermayer writes:
 > >  > On Sunday 19 October 2003 20:19, Diego Biurrun wrote:
 > >  > [...]
 > >  >
 > >  > >  > anyway since a while the vf_scale filter can do bri/contrast
 > >  > >  > changes too so 'eq' is getting outdated/redundant.
 > >  > >
 > >  > > How can vf_scale do b/c changes?  It's not documented..
 > >  >
 > >  > vf_scale will trap VFCTRL_SET_EQUALIZER, and adjust the b/c/s
 > >  > accordingly if it can, allthough its only possible ATM if YUV->RGB is
 > >  > done, we surely could also run some eq like filter in the scaler if
 > >  > YUV->RGB is not done but that wouldnt be any faster then using the eq
 > >  > filter directly ...
 > >
 > > Can you dumb this down a bit ;-)
 > >
 > > Do you mean it reacts to the -brightness and -contrast options?  How
 > it should, ... but seems it doesnt 

It's somewhat buggy.

  mplayer -brightness 100 movie.avi

starts up normal, but when I press '3' it jumps to maximum brightness
at once, same for contrast.  Tested wit vo_xv and vo_xmga.

 > > else can you set bri/con if not like this or through a filter?
 > with the keyboard (1/2 is con 3/4 is bri, ...), its hopefully in the manual 
 > ...

It is.

Diego