[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[Hampa Hug]

Diego Biurrun wrote:

> Arpi writes:
>  > vf_eq2 is mostly used for gamma settings, and so its normal and natural
>  > that gamma is the first (and recommended) parameter.
>  > others (contrast brightness etc) are rarely used with this filter,
>  > a sthere are much more faster and efficient filters for that (vf_eq and
>  > scale, but most users don't need them as vo driver can do it as well)
> 
> Hmm, if I understood the discussion correctly, then vf_eq2 is as fast
> as vf_eq if no gamma correction is used.  The man page suggests the
> same:
> 
>   eq2[=gamma:contrast:brightness:saturation:rg:gg:bg]
>     Alternative software equalizer that uses lookup tables (very
>     slow), allowing gamma correction in ad dition to simple brightness
>     and contrast adjustment.  Note that it uses the same MMX optimized
>     code as -vf eq if all gamma values are 1.0.
> 
> Is this wrong?  You also said that vf_eq was obsolete and should be
> superseded by vf_eq2, so I assumed there was no speed penalty.

This is correct. The code was copied over from vf_eq to vf_eq2.


> In the beginning of this thread is a patch that leaves gamma as first
> parameter.  Is it OK to commit that one?  The parameter order is easy
> to change later (if we should want to).

Don't use the first patch (eq2.diff), it won't apply anymore.
Changeing parameter order should be simple in the latest patch
(eq2-2.diff). Or, if we can settle this, I can make a new
patch. What's it gonna be? (I really think it's a non-issue)

Hampa