[MPlayer-dev-eng] [PATCH] some trivial fixes [GUI, too]

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 28 October 2003, Diego Biurrun wrote:
Content-Description: message body text
> Dominik 'Rathann' Mierzejewski writes:
>  > On Sunday, 26 October 2003, Diego Biurrun wrote:
>  > > Dominik 'Rathann' Mierzejewski writes:
>  > >  > Here are some trivial patches I made over the last few weeks:
>  > >  > mplayer-faad2_local.patch: fixes building with system faad2
>  > > 
>  > > Hmm, why this?  It works for me without it..
>  > 
>  > Without this, it still tries to build the included faad2 and my gcc-3.1
>  > is broken and throws an ICE.
> 
> I just had a quick look at this, the FAAD detection is a real mess.  I
> tried to understand what your patch was doing, but couldn't,

Essentially, it ensures that if I enable external faad, then internal
faad is not compiled.

> so I
> rewrote this.  It's shorter and cleaner now.  It tries internal FAAD
> first and then falls back to detecting system FAAD (before you would
> have to pass --enable-external-faad explicitly).  I tested it under
> Cygwin with a broken gcc, it's working flawlessly for me now.  Please
> test the attached patch.  If it works for you I'd like to commit
> this.  Any objections?

I'll try to test this tonight.

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"