[MPlayer-dev-eng] [PATCH] remove --enable-smb option

Diego Biurrun diego at biurrun.de
Tue Oct 28 12:37:33 CET 2003


Götz Waschk writes:
 > this patch removes the --enable-smb option from configure. With the
 > current CVS, the build will fail with --enable-smb, as the
 > autodetection of the smbclient libs is skipped. So there are two
 > alternatives:
 > 1. remove the useless --enable-smb option and keep the default
 > autodetection
 > 2. use autodetection if _smbsupport is set to auto or yes.
 > 
 > I'd prefer number 1, what about you?

This is broken, we always have both options, you should instead fix
the test so it also runs when --enable-smb is specified or something
like that.

Anyway, if you force an option that is autodetected, you should make
sure the build does not break yourself.

Diego



More information about the MPlayer-dev-eng mailing list