[MPlayer-dev-eng] [PATCH] Forced subtitles[corrected]

Diego Biurrun diego at biurrun.de
Tue Oct 21 03:38:03 CEST 2003


Arpi writes:
 > >  > >
 > >  > > Patch attached.
 > >  > btw, a few lavc options use underscores too, so they should be changed too if 
 > >  > we change _ -> -
 > > 
 > > Hmm, just had another look, all lavcopts use _, so they are at least
 > > consistent among themselves.  Shall we change all of them to - also?
 > 
 > you shouldnt change any option wihtout a very very good reason!
 > it will make more trouble for users (having options with _ in configfile,
 > scripts, in frontend codes etc) than help

You have a point.  So maybe we should leave the lavcopts as they are.

But I'm still convinced that we should do the change for the mplayer
options.  Consistency is very important, it is a big part of a
(positive) user experience.  Besides the few options that use _ are
very obscure with the exception of -stop_xscreensaver, but my patch
prints out a warning for that one.

Diego




More information about the MPlayer-dev-eng mailing list