[MPlayer-dev-eng] [PATCH] Endpos for Mplayer.

Jason Tackaberry tack at auc.ca
Mon Oct 20 16:21:29 CEST 2003


On Mon, 2003-10-20 at 10:06, Konstantinos Karydas wrote:
> Please advice if I am doing something wrong. An example of the diff -Naur
> usage would be very helpful.

Your diff of cfg-common.c is very wrong.  I recommend you actually read
the patches before submitting them.  (With these diffs, lines prefixed
with a "+" are to be added, and lines prefixed with a "-" are removed,
so with a quick glance it's easy to see if the patch looks right.) 

Surely this file isn't supposed to have binary junk at the beginning and
ends?  Surely you haven't touched every line of cfg-common.c?

Your other patches look okay, so the problem isn't your usage of diff
but rather that either the src or dest file from your cfg-common.c patch
is messed up.

Jason.



More information about the MPlayer-dev-eng mailing list