[MPlayer-dev-eng] [PATCH] Revised -saveidx support, with documentation

[Diego Biurrun]

On Sun, Oct 12, 2003 at 10:32:30PM -0400, Jason Tackaberry wrote:
> This update includes sanity checking of index files and is more robust,
> and as well removes the inappropriate exit() calls.  Also, the English
> man page is updated to include descriptions of the two new options,
> -saveidx and -idxfile.

Thanks for the docs update, here are some comments:

> --- main.orig/DOCS/en/mplayer.1	2003-10-08 14:38:23.000000000 -0400
> +++ main/DOCS/en/mplayer.1	2003-10-12 22:08:53.000000000 -0400
> @@ -768,6 +768,16 @@
>  You can only use this option if the underlying media supports seeking
>  (i.e. not with stdin, pipe, etc).
>  .TP
> +.B \-idxfile  <filename>
> +The file name written to or read from for the INDEX data.  When

Each new sentence should start on a line of its own.

> +specified in conjunction with -saveidx, MPlayer will force generation of

You should escape all option names: \-saveidx

> +the AVI index and write it to filename.  When -saveidx is not specified

same here

> +on the command line, MPlayer will read the index from filename and use
> +this data for seeking.  This data will override any index data contained
> +in the AVI itself.  Further, MPlayer won't prevent you from loading an
> +index file generated from a different AVI, but this is sure to cause
> +unfavorable results.
> +.TP
>  .B \-ipv4-only-proxy
>  Skip the proxy for IPv6 addresses.
>  It will still be used for IPv4 connections.
> @@ -875,6 +885,18 @@
>  This option may be useful if you have a broken Internet connection that does
>  not pass incoming UDP packets (see http://www.live.com/mplayer/).
>  .TP
> +.B \-saveidx
> +Force rebuilding of INDEX and output to a separate file specified with
> +-idxfile.  Currently this only works with AVI files.  Although you can

same here

> +use MEncoder to fix files without indexes, MPlayer does not support
> +seeking in AVI files bigger than 2G.  (This is a limitation of the AVI

For extra consistency, please say 2GB instead of 2G.

> +format, and although there exists an extension to index beyond 2G,

again, 2GB

> +MPlayer doesn't yet support this extension.)  After the index file is
> +created, MPlayer will begin to play the video.  If you want to automate
> +index file generation (after encoding a large file off a TV capture
> +card, for example), you can specify -frames 0 to prevent MPlayer from

\-frames

> +playing the video after generating the index.
> +.TP

Diego