[MPlayer-dev-eng] [PATCH] fix vo_tdfxfb with gcc 3.x

[Jesús Sánchez]

El Lunes, 13 de Octubre de 2003 11:17, Attila Kinali escribió:
> On Sun, 12 Oct 2003 15:34:37 +0200
>
> Jesús Sánchez <gusanje at yahoo.es> wrote:
> > I found that the tdfxfb video output driver doesn't work when compiled
> > with gcc 3.x. The OSD works fine, but the video size is not adjusted
> > properly (it is always the same size as a console character). This patch
> > corrects it (at least it works on my system). Tested with gcc 3.3.1 and
> > gcc 2.95.4.
>
> Hmm ? Does this patch do anything ?
>
> 			Attila Kinali

I know it is so simple that it seems it doesn't do anything ;-). The trick is 
just a 'volatile' added for reg_2d. This is a pointer to some video card 
registers mapped in memory. Perhaps, gcc 3.x optimizes too much, and when 
reg_2d is written it doesn't update the real registers. In particular, this 
line didn't work:
	reg_2d->dstSize = XYREG(vidwidth, vidheight);
The rest of the patch only deletes some lines added by an old patch that tried 
to fix the same issue.

Jesús Sánchez