[MPlayer-dev-eng] ARM (arm920T, mplayer-1.0pre1) bug & Q.

[Sangwook Lee]

ENV : arm920t, Linux, X11
mplayer-1.0pre1 

1.  
I am using mplayer-1.0pre1 for ARM CPU
  but in bswap.h file might have a bug for ARM CPU.
  original code makes wrong video decoded data.

82,83c82,87
< #define bswap_16(x) (((x) & 0x00ff) << 8 | ((x) & 0xff00) >> 8)
< 			
---
> /* SW.LEE */
> /* Bug fixed */
> #define bswap_16(x) \
> 	    (__extension__
\
> 	          ({ unsigned short int __bsx = (x);
\
> 		           ((((__bsx) >> 8) & 0xff) | (((__bsx) & 0xff) <<
8)); }))
85,88d88
< // code from bits/byteswap.h (C) 1997, 1998 Free Software Foundation, Inc.
< #define bswap_32(x) \
<      ((((x) & 0xff000000) >> 24) | (((x) & 0x00ff0000) >>  8) | \
<       (((x) & 0x0000ff00) <<  8) | (((x) & 0x000000ff) << 24))
90c90,96
< static inline uint64_t ByteSwap64(uint64_t x)
---
> #define bswap_32(x) \
>         (__extension__                                                 \
>       ({ unsigned int __bsx = (x);                                       \
>        ((((__bsx) & 0xff000000) >> 24) | (((__bsx) & 0x00ff0000) >>  8) |
\
>          (((__bsx) & 0x0000ff00) <<  8) | (((__bsx) & 0x000000ff) <<
24)); }))
> 	    
> static  inline uint64_t ByteSwap64(uint64_t x)


2.  
   I tested some mpeg files
     mp3 file : ok
     mpeg4 video (mov file ) : ok
     mpeg4 aac file : has problems 
                --> 
                -->  "Your system is too SLOW to play this!"
     I don't know why this kind of erro happens.
    



The feedback that I receive from linuxer is vital for me to bring you
better linux solutions.
 if you have any suggestions please feel free e-mail me with your comments.

_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/
_/
_/   Sangwook Lee
_/   ☏: +82-(0)31-279-7634
_/   E-mail:hitchcar at sec.samsung.com
_/   Samsung Electronics Co.,Ltd.
_/
_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/