[MPlayer-dev-eng] [PATCH] vf_crop to pass on field-order

[Arpi]

Hi,

> > > +	    vf->dmpi->fields ^= MP_IMGFIELD_TOP_FIRST;
> > [..]
> > > +	dmpi->fields ^= MP_IMGFIELD_TOP_FIRST;
> > 
> > Should those here really be XOR ?
> 
> Yes, if you crop odd number of lines from the top, then previously top
> field becomes the bottom field (i.e. previously even lines become the
> odd lines), so the MP_IMGFIELD_TOP_FIRST flag should be inverted.  If
> not XOR, what else culd you use?
> 
> Zoli

actually we shouldnt allow cropping odd numbe rof lines from top and left.
it will also trash chroma upsampling at 4:2:0 formats.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu