[MPlayer-dev-eng] [PATCH] fix to -geometry switch in xv driver

[Steve]

Oh ... ok

As you guessed, I was concentrating on the xv driver. I had assumed 
that the -geometry option was functional in the other vo modules.

If the other modules are conceptually similar to the xv module then 
most certainly aspect() would be a good place to make the change. I 
could create a patch for you but am not able to verify the other 
modules.

BTW The printf was an "oops" which I intended to remove before 
creating the patch. Sorry!

Steve

On Thursday 09 October 2003 09:18, Attila Kinali wrote:
> On Thu, 9 Oct 2003 09:06:02 +0100
>
> Steve <sgbmplayer at ironmountainsystems.com> wrote:
> > Can someone try this and let me know if it works for you, the
> > patch to 1.0pre2 update the xv driver so the -geometry switch
> > works correctly.
>
> Looks fine imho, but the way it's done is not good.
> geometry is used in quite a few vo modules, so the patch should
> be done in all. On the other hand aspect is used in nearly all
> modules. Thus, it would be better to change aspect and geometry,
> but this has do be done carefully as it can lead to certain
> unexpected behaviour.
>
> BTW: if you would read the manpage you'd see that you have
> to use -geometry -noaspect (eventualy with -nozoom if you have
> -zoom in your config file).
>
> BTW2: dont use printf in mplayer modules, use mp_msg instead
>
> This aspect/geometry stuff is still on my todo list, i'll
> look at it after i finished all the paperwork overhere.
>
>
> 			Attila Kinali