[MPlayer-dev-eng] [MPlayer-users] [PATCH] Re: Remove avi header info? (fwd)

[Alex Beregszaszi]

Hi,

> Should we commit this? (See discussion on -users) IMO the patch isn't
> quite correct as-is but is very much a desirable feature.
Why? Why should one change the software info tag to Nandub when encoding
with mencoder? The field is there for easier bug recognition ;)

> @@ -224,10 +225,12 @@
>  
>  // ============= INFO ===============
>  // always include software info
> -info[0].id=mmioFOURCC('I','S','F','T'); // Software:
> -info[0].text="MEncoder " VERSION;
>  // include any optional strings
> -i=1;
> +i=0;
> +if(info_software==NULL||info_software[0]){
> +  info[i].id=mmioFOURCC('I','S','F','T'); // Software:
> +  info[i++].text=(info_software!=NULL)?info_software:"MEncoder";
don't change the old behaviour, e.g. don't remove the VERSION tag


-- 
Alex Beregszaszi <alex at fsn.hu>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)