[MPlayer-dev-eng] [PATCH] directx keys

Sascha Sommer saschasommer at freenet.de
Sun Nov 23 14:49:25 CET 2003


> Hello,
> 
> Here's a patch to fix a bug found when 'q' is not bound to 'quit'.
> 
> Also, mplayer keycodes.h says CTRL and BS are the same,
> so i replace CONTROL with BACK.  Windows keys are not
> the same for these two, but mplayer input layer can't
> think of them as different, so I replace instead of add.
> 
> Without this patch, pressing backspace on console makes mplayer say
> 'no key for CTRL' and pressing backspace on directx window sends
> keycode 0x8 to input layer.
> 
> If this is wrong to change in vo_directx, then I say KEY_BACKSPACE
> should be changed to 0x8 instead of (CTRL+0) in keycodes.h.  I
> haven't tested on linux, if this is wrong too, then my final
> suggestion is changing KEY_BS to 0x8 if defined MINGW or something.
> 
> But the first chunk is obviously correct.
> Okay to commit, and which part?
> 

Commit both.

Sascha



More information about the MPlayer-dev-eng mailing list