[MPlayer-dev-eng] [PATCH] win32 ao

Sascha Sommer saschasommer at freenet.de
Sun Nov 23 14:47:35 CET 2003


> Hello,
>
> The last in my round of patches!
> This one is for win32 ao, and it fixes a bug in the fallback config
> code.
>
> If win32 ao configure fails, then it falls back on 44k S16_LE 2ch.
> when it falls back, though, bps is not set consistently with the way
> it would be from an original config of 44k S16_LE 2ch.
>
> To reproduce, try -ao win32 -channels 6
> or something like that your card won't support.
> I get really terrible performance with this.
>
> This patch fixes it.
>
> original config:
> > ao_data.bps=channels*rate;
> > if(format != AFMT_U8 && format != AFMT_S8)
> >   ao_data.bps*=2;
>
> fallback:
> > ao_data.bps=ao_data.channels * ao_data.samplerate;
> then since we forced the format to S16_LE, we should double bps to be
consistent.
>
> Okay to commit?
>
yes

Sascha



More information about the MPlayer-dev-eng mailing list