[MPlayer-dev-eng] [PATCH] new faad detection in configure

[James Bilotto]

On Fri, Nov 07, 2003 at 05:41:45PM +0100, Diego Biurrun wrote:
Content-Description: message body text
> James Bilotto writes:
>  > On Fri, Nov 07, 2003 at 02:20:49PM +0100, Diego Biurrun wrote:
>  > > On Fri, Nov 07, 2003 at 04:02:06AM -0800, James Bilotto wrote:
>  > > > On Fri, Nov 07, 2003 at 11:16:46AM +0100, Björn Sandell wrote:
>  > > > > On Fri, 7 Nov 2003 02:12:41 +0100
>  > > > > Diego Biurrun <diego at biurrun.de> wrote:
>  > > > > 
>  > > > > > 
>  > > > > > I've reworked my faad detection patch a bit, Dominik, James Bilotto,
>  > > > > > Björn Sandell please test, this should also fix the version detection.
>  > > > > 
>  > > > > Nope. Well, it works with --disable-internal-faad:
>  > > > 
>  > > > the same hear. with some modifications it will thou. patch against cvs
>  > > 
>  > > > -  if cc_check $_inc_faad $_ld_faad -lm && "$TMPO" >> "$TMPLOG" ; then
>  > > > +  if cc_check -I- $_inc_faad $_ld_faad -lm && "$TMPO" >> "$TMPLOG" ; then
>  > > 
>  > > That is the same change I made in the latest version.  Please try my latest
>  > > patch.  Thanks
>  > 
>  > you missed this part
>  > 
>  > +# external faad: check if it's really faad2 :)
>  > +echocheck "external FAAD2 (AAC) support"
>  > +if test "$_faad_external" != no ; then
>  > +  _ld_faad='-lfaad'
>  > +  _inc_faad="$_inc_extra"
>  > 
>  > --enable-external-faad will fail without it. can't find the header
> 
> Hmmmm
> 
>  > +  _inc_faad="$_inc_extra"
> 
> This is just a workaround.  I call
> 
>   cc_check $_inc_faad $_ld_faad -lm && _faad_external=yes
> 
> and the compile call of cc_check is this:
> 
>   ( $_cc $CFLAGS $_inc_extra $_ld_static $_ld_extra "$TMPC" -o "$TMPO" "$@" )

it's not a work around, it's their on purpose for the version checking

cc_check -I- $_inc_faad $_ld_faad -lm && "$TMPO" >> "$TMPLOG" ; then
         ^^^
from gcc's man page

 -I-    Any directories you specify with `-I' options before  the  `-I-'
              option are searched only for the case of `#include "file"'; they
              are not searched for `#include <file>'.