[MPlayer-dev-eng] [PATCH] new faad detection in configure

[Diego Biurrun]

Björn Sandell writes:
 > On Fri, 7 Nov 2003 02:12:41 +0100
 > Diego Biurrun <diego at biurrun.de> wrote:
 > 
 > > I've reworked my faad detection patch a bit, Dominik, James Bilotto,
 > > Björn Sandell please test, this should also fix the version detection.
 > 
 > Nope. Well, it works with --disable-internal-faad:
 > 
 > $ ./configure --with-extralibdir=/usr/local/lib \ 
 >  --with-extraincdir=/usr/local/include
 > 
 > Checking for internal FAAD2 (AAC) support ... yes
 > Checking for external FAAD2 (AAC) support ... no
 > Checking for FAAD2 version ... 1.1
 > 
 > $ ./configure --with-extralibdir=/usr/local/lib \
 >  --with-extraincdir=/usr/local/include --enable-external-faad
 > 
 > Checking for internal FAAD2 (AAC) support ... yes
 > Checking for external FAAD2 (AAC) support ... no
 > Checking for FAAD2 version ... 1.1

Argh, that is a bug in my patch, fixed.

 > $ ./configure --with-extralibdir=/usr/local/lib \
 >  --with-extraincdir=/usr/local/include --disable-internal-faad
 > 
 > Checking for internal FAAD2 (AAC) support ... no
 > Checking for external FAAD2 (AAC) support ... yes
 > Checking for FAAD2 version ... 1.1
 > 
 > Same problem as earlier, when checking version faad.h in $_inc_extra is
 > used instead of the one in $_inc_faad.
 > 
 > Attached patch to your patch works for me.
 > 
 > -  if cc_check $_inc_faad $_ld_faad -lm && "$TMPO" >> "$TMPLOG" ; then
 > +  if ($_cc $_inc_faad $_inc_extra $_ld_faad $_ld_static $_ld_extra -lm "$TMPC" -o "$TMPO") && "$TMPO" >> "$TMPLOG" ; then

This is ugly, you are removing the cc_check abstraction.  Adding -I-
after cc_check does the trick for me.  Please try my updated patch.

Diego


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: faad_configure2.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031107/ee40def4/attachment.asc>