[MPlayer-dev-eng] [PATCH][BUG] fbdev fix, fbdev2 needs testing

[D Richard Felker III]

On Mon, May 26, 2003 at 01:02:06AM -0500, Joey Parrish wrote:
> Hello,
> 
> I've cleaned up vo_fbdev rather than rewriting it, because a lot of
> worthwhile work seemed to have already been done.  I removed a great
> deal of code, though, to make it simpler.
> 
> What I need now is for people to test it for me, because it works great
> on my system (using vesa fb device) but I can't test anywhere else.
> 
> big changes:
>  - removed lots of #includes
>  - removed odd video_out_png def
>  - changed all printf to mp_msg
>  - removed all mode switching code
>  - removed fb.modes parser
>  - commented the static globals i left in
>  - changed var name "L123123789" to "center"
>   -- by the way, how did that come to be named L123123789?
no idea, agree it was dumb...
>  - removed a few unused or useless variables
>  - removed vidix
heh, not sure this is a good idea, but vidix does suck...
>  - removed all the /dev/tty stuff
THANK YOU!!
>  - made a few functions static
>  - changed the way fb_preinit works
>   -- fixed a small bug in vo_fbdev this way (explained below)
>  - tried to make multiple config calls nicer
>  - removed YV12 support
>  - added slices support for RGB modes
how abour dr too? it would be better with vf_scale!
>  - made RGB modes the only available modes (let vf_scale convert)
>  - fixed uninit problems
> 
> improvements:
>  - much cleaner, smaller code (1305 lines -> 398 lines)
:))
>  - slices support
:)))))))
>  - can change vt while playing movies
:))
>  - bugfixes
> 
> not sure:
>  - double buffering is decided just as in vo_fbdev (USE_CONVERT2FB)
>   -- should it be?
eh? i think this was fake double buffering anyway...only good for
stopping osd flicker, not shearing... :(
>  - no mode switching except color depth (this seems possibly bad)
>   -- but it simplified things a lot and i don't need it.  :)
>  - i'm not sure i like the in_* out_* vars
>   -- but this system still works well
>  - i'm not sure i like the preinit system
>   -- but it also works
>  - no draw_frame, is this okay if slices work for all csp?
not sure

rich