[MPlayer-dev-eng] Call for unapplied patches

[Arpi]

Hi,

>  	for(i=0;i<len;i++)
> -	((int32_t*)in_data)[i]=(int32_t)(((uint32_t*)in_data)[i]-0x80000000);
> +	((int32_t*)in_data)[i]=(int32_t)(-0x7FFFFFFF+((uint32_t*)in_data)[i]);
>  	break;

this is bad!
the 'conversion factor' between signed and unsigned samples is 0x80000000
and not 0x7fffffff !
btw if you (or gcc:)) likes it better, ^ can be used instead of -

> --- MPlayer-20030323/libvo/vo_dga.c.warn	Tue Feb  4 17:14:54 2003
> +++ MPlayer-20030323/libvo/vo_dga.c	Sun Mar 23 12:24:40 2003
> @@ -555,6 +555,7 @@
>         // as long as it's above 50 Hz (acki2 on 30/3/2001)
>         ||
>         (
> +	(
>  	(new_x == *old_x) &&
>  	(new_y == *old_y) &&
>  	(
> @@ -568,6 +569,7 @@
>  	  new_vbi >= 50
>  	 )
>  	)
> +	)
>          ||

hehe my favourite one :)
it was posted many many times but never applied :)
i don't know if it's correct (and i can't even test), and others seem to
ignored too


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu