[MPlayer-dev-eng] [PATCH] Possible SDL aspect bug, quick workaround

[Fredrik Roubert]

On Fri 23 May 15:16 MEST 2003, Alex Beregszaszi wrote:

> attached a patch, which should do the same as yours.
> If that works, I will apply it, so reply fast! :)

Sorry, that patch doesn't do the same as mine.

If you enable ASPECT_DEBUG (line 7 in libvo/aspect.c) then you can see
the following in the debug output with your patch applied:


$ mplayer -v -vo sdl:dga aliens.avi

MPlayer dev-CVS-030520-17:25-3.2.3 (C) 2000-2003 Arpad Gereoffy (see DOCS)

VIDEO:  [DIV3]  720x480  24bpp  23.98 fps  720.3 kbps (87.9 kbyte/s)

Starting playback...
[ffmpeg] aspect_ratio: 0.000000
VDec: vo config request - 720 x 480 (preferred csp: Planar YV12)
Trying filter chain: vo
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is undefined - no prescaling applied.
VO Config (720x480->720x480,flags=0,'MPlayer',0x32315659)
VO: [sdl] 720x480 => 720x480 Planar YV12
VO: Description: SDL YUV/RGB/BGR renderer (SDL v1.1.7+ only!)
VO: Author: Ryan C. Gordon <icculus at lokigames.com>, Felix Buenemann <atmosfear at users.sourceforge.net>
aspect: Warning: no suitable new res found!
SDL: Using 0x32315659 (Planar YV12) image format
aspect_save_orig 720x480
aspect_save_prescale 720x480
SDL: using hardware-surface
aspect_save_screenres 1024x768
aspect(0) fitin: 1024x768 zoom: 0 screenaspect: 1.33
aspect(1) wh: 720x480 (org: 720x480)
aspect(2) wh: 720x480 (org: 720x480)
aspect(3) wh: 720x480 (org: 720x480)
SDL: setting zoomed fullscreen with modeswitching
SDL Mode: 0:  1024 x 768
SDL Mode: 1:  800 x 600
SDL Mode: 2:  768 x 576
SDL Mode: 3:  720 x 576
SDL Mode: 4:  720 x 480
SDL Mode: 5:  640 x 480
SDL Mode: 6:  584 x 438
SDL Mode: 7:  400 x 300
SDL Mode: 8:  352 x 288
SDL Mode: 9:  352 x 240
SDL Mode: 10:  320 x 240
SET SDL Mode: 4:  720 x 480
aspect_save_screenres 720x480
aspect(0) fitin: 720x480 zoom: 1 screenaspect: 1.33
aspect(1) wh: 720x480 (org: 720x480)
aspect(2) wh: 720x426 (org: 720x480)
aspect(3) wh: 720x426 (org: 720x480)
*** [vo] Allocating (slices) mp_image_t, 720x480x12bpp YUV planar, 518400 bytes
*** [vo] Allocating (slices) mp_image_t, 720x480x12bpp YUV planar, 518400 bytes


The movie is scaled from 720x480 to 720x426. With my patch applied,
you'd have to specify -zoom in order to get this behaviour. Note that
specifying -nozoom doesn't change the behaviour in this case in the CVS
MPlayer or MPlayer with your patch applied.

Cheers // Fredrik Roubert

-- 
Möllevångsvägen 6c  |  +46 46 188127
SE-222 40 Lund      |  http://www.df.lth.se/~roubert/