[MPlayer-dev-eng] [PATCH] Mac OS X native audio output

Wojtek Kaniewski wojtekka at bydg.pdi.net
Thu May 22 17:28:43 CEST 2003


On Thu, 22 May 2003, D Richard Felker III wrote:
> > maybe this patch would help? it modifies MP_CMD_VOLUME a bit. if
> > af_volume is loaded, it uses its control interface instead of the
> > mixer_*() functions.
> 
> IMO it would make more sense to put this change *in* the mixer_*
> functions, like it was before for pl_volume.

unfortunately mixer functions know nothing about audio stream, so i
couldn't find any way to get af_stream_t for af->control(). and passing
af_stream_t to mixer_setvolume() and the rest doesn't seem to be elegant
solution.

> Ideally, it should pass
> volume get/set commands down the af filter chain, to be intercepted by
> the first volume filter if present, and otherwise by the ao. However,
> I'm not sure libaf was that well-designed... :(

i've written af_control() that passes control request to the first or
all audio filters that can handle it. but it's useless if mixer
functions don't know af_stream_t.

regards,
wojtek



More information about the MPlayer-dev-eng mailing list