[MPlayer-dev-eng] PATCH: signal handling in gmplayer, immediate mode in tvi_v4l, wrong warning for tv:// MRLs

[D Richard Felker III]

On Tue, May 20, 2003 at 11:22:14AM +0200, Arpi wrote:
> Hi,
> 
> > hi.
> > On Tue, 20 May 2003 10:50:59 +0200
> > Arpi <arpi at thot.banki.hu> wrote:
> > 
> > >> MJ> 1: mp_msg() in gmplayer uses GTK message boxes, and this is REALLY a
> > >> MJ> stupid idea inside a signal handler! This makes gmplayer 'almost
> > >> 
> > >> mp_msg() in signal handler is stupid idea even without gui =/
> > 
> > A> hmm, i tend to agree :)
> > A> so feel free to change it... to fprintf maybe
> > A> btw gui users won't know what happened to mplayer when it crashing,
> > A> but who cares :)
> > 
> > according to "info libc" fprintf is nonreentrant and should not
> > be used in signal handlers.
> 
> so then what is the allowed method of printing from sighandler?

sprintf to a string buffer and write() it to fd #2.

Rich