[MPlayer-dev-eng] [PATCH] two small fixes for vo_xv

Tom Lees tal26 at cam.ac.uk
Mon May 19 11:56:20 CEST 2003


On Sun, 2003-05-18 at 15:12, Attila Kinali wrote:
> This makes somewhat sense, on the other hand, it worked
> fine until now...

But it wasn't working correctly - it would completely ignore the aspect
calculation it just did since hint.(width|height) are used to set the
window size and the draw size. (The aspect for anamorphic stuff is
already set up in the input to this function, so that wasn't broken)

> >  #ifdef HAVE_XF86VM
> >      if ( vm )
> >        {
> > @@ -382,10 +382,13 @@
> >          XSetWMNormalHints( mDisplay,vo_window,&hint );
> >  	XMapWindow(mDisplay, vo_window);
> >  	if ( flags&1 ) vo_x11_fullscreen();
> > +	else
> > +	{
> >  #ifdef HAVE_XINERAMA
> >  	vo_x11_xinerama_move(mDisplay,vo_window);
> >  #endif
> >  	vo_x11_sizehint( hint.x, hint.y, hint.width, hint.height,0 );
> > +	}
> >      } else  {
> >  	// vo_fs set means we were already at fullscreen
> >  	vo_x11_sizehint( hint.x, hint.y, hint.width, hint.height,0 );
> > 
> 
> This is bad, this will disable the xinerama code if the movie is shown
> full screen. (or do you really want to splitt the movie over several
> monitors ?)

No, vo_x11_fullscreen() (in x11_common.c) handles the xinerama stuff as
well (with exactly the same call) after it's set the wnidow size for
fullscreen.

Tom



More information about the MPlayer-dev-eng mailing list