[MPlayer-dev-eng] [TEST PATCH] How to get rid of all sscanf() or new face of config :)

Alban Bedel albeu at free.fr
Thu Mar 27 13:01:00 CET 2003


Hi Andriy N. Gritsenko,

on Tue, 25 Mar 2003 23:34:21 +0200 you wrote:

> 2anyone: Please, try it and send me your complains and so on. :)

I don't like this patch. For me it's partially a step back, or at best i
don't see any improvement. First of all, for the filters you just use a
static struct for each filter type. Each filter must get his own parameters
you can't use a common var for that.
Also the 'defaults' are there for something. If the user deosn't set a
value for an option from where should you know the default value ?

For the help messages, imho it's not a so good idea. Dunno what other ppl
think but i don't think that it's worth it considering the inpact on the
cvs logs. If we manage to have a converter to convert the man page to a
simplfied xml it is then very easy to add help messages (the asx parser can
be used for that).

As you know i allrdy implemented something similar wich is imho much
simpler, so i can't see any reason to apply such thing.

	Albeu



More information about the MPlayer-dev-eng mailing list