[MPlayer-dev-eng] Offer of help to get me started
evil_kosh_uk at yahoo.co.uk
Mon Mar 24 01:59:50 CET 2003
On Mon, 2003-03-24 at 00:55, Anders Rune Jensen wrote:
> Evil Kosh <evil_kosh_uk at yahoo.co.uk> writes:
> > Hi,
> > I'd like to start a bit of coding on mplayer and I thought the best way
> > to get acquainted with the code and how it works is to look through it
> > and see what I could fix. I immediately saw that there were a number of
> > different styles that people were developing with.
> > Some people would use braces with for and if statements, others would
> > not, some people would put the break in a case statement before the
> > closing brace, others would not. I thought perhaps it would be a good
> > idea to get acquainted with the code and help out at the same time.
> > Also I found some parts of the code with tabbed indentations and others
> > with space indentations.
> > Would anyone here object to a clear style guide being formed from the
> > developers here? I'd be happy to reformat the code along those
> > guidelines, if it means I can help out, everyone gets clear, well
> > formatted code along an agreed style.
> > What do you think? well, I'm 1/2 way through reformatting mplayer.c
> > with what I think is a good style. It's consistant anyhow. So if
> > people dont like it then I can always alter it. I'll post it to the
> > list when I've finished and let people judge for themselves whether they
> > think this reformatting exercise is a good idea or not.
> Ever heard of pretty printers?
I think I understand what you are trying to say. There is however a
limit to the amount of automated reformatting tools can do before you
have to manually go in and change the formatting in such a way you can
rerun the automated reformatting tool again, or complete it manually.
I'm simply suggesting that people agree on one style and it's something
I can help implement. I'm not trying to make the source beautiful, I'm
trying to smooth the code out so it's more readable and accessible. It
was my first thought when I read the code, that it was unreadable in
certain parts. So the first thing I would like to help with, is making
it more accessible to people like me.
> > thanks for listening and I hope a favourable response.
Evil Kosh <evil_kosh_uk at yahoo.co.uk>
More information about the MPlayer-dev-eng