[MPlayer-dev-eng] [PATCH] mga_vid and tdfx_vid char-major with module parameter

Alban Bedel albeu at free.fr
Sat Mar 15 10:49:04 CET 2003


Hi Arpi,

on Sat, 15 Mar 2003 00:07:49 +0100 you wrote:

> Hi,
> 
> > > This patch adds a module parameter "major" to the
> > > mga_vid.o module. This allows to use a different major
> > > number than 178 at runtime. This is the same parameter 
> > > name as in other kernel modules, e.g., in "pd", "pf", and 
> > > "pg".
> > > 
> > BTW for tdfx_vid i just used the same major,minor as mga_vid. That's
> > probably not a so good idea.
> 
> why? are you using totaly incompatible apis?
Yes, thus the overlay could perhaps be common. It's mostly bcs i first
thought that the tdfx overlay was only for video input (and my card don't
have that). So i first focused on the agp transfert, then i saw that the
overlay was useable so i added it.
Imho me shouldn't try to get api compatibilty with the *_vid drivers. These
drivers should let you use the card in the best possible way. For example
on the tdfx the screen blit are essestial as they can do colorspace
conversion and stretching. For more general drivers there is vidix.

> the mga_vid api allow version checking and quert card id.
> it should be enough to detect teh crrect module
I sould rather use another major, in case someone have a matrox and a tdfx.
	Albeu


More information about the MPlayer-dev-eng mailing list