[MPlayer-dev-eng] [PATCH] resubmit realv4.diff

Arpi arpi at thot.banki.hu
Sat Mar 8 18:51:10 CET 2003


Hi,

> > > > -			    if(dp_data[dp_hdr->len]&0x20) --dp_hdr->chunks; else
> > > > +			    if((dp_data[dp_hdr->len]&0x20) && (sh_video->format!=0x30345652))
> > > > --dp_hdr->chunks; else
> > > >
> > > > to fix rv40 frames cut in the middle.
> > >
> > > imho it's bad fix.

yes, the correct one is:
if((dp_data[dp_hdr->len]&0x20) && (sh_video->format==0x30335652)) --dp_hdr->chunks; else

> > > if they are cut in middle, it means that rv40 stores number_of_chunks/4
> > > in header byte (probably to allow up to 4*64==256 slices) instead of
> > > number_of_chunks/2 like in rv20/rv30.

forget this, i thought something different then...

btw please don't commit to real code now, i'm working on that right now
(have most of Denes's fixes merged locally, mostly with some modifications)

for example the ugly width*height detection in vd)realvid seems to
be required for rv40 too, see crash.rmvb at incoming

the ad_realaud is also fixed, the &0x0F is bad, the right fix is
if(!priv) i_bps=12000;

don't ask me why...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
[Using mailer3 v3.99pre3-CVS beta GSM edition, broken Date: feature enabled]



More information about the MPlayer-dev-eng mailing list