[MPlayer-dev-eng] [PATCH] resubmit realv4.diff

[Michael Niedermayer]

Hi

On Wednesday 05 March 2003 23:51, Balatoni Denes wrote:
> Hi!
>
> I resubmit in case you forgot.
hmm IIRC arpi didnt like it

i wont apply such cryptic code, because it makes future maintainence very 
difficult even if its correct

0x303?5652 should perhaps be replaced with #defined values or add some 
rv_version variable perhaps, yes its allready there before your patch but it 
makes reviewing the patch more difficult

the kf change from *2 to *4 looks like some additional bit has been inserted, 
in which case this would be wrong

+  if( ( ( s[0] & (~0xf) ) ==0 ) || ( ( s[0] & (~0xf) ) ==0x40 ) ||
+     ( ( s[0] & (~0xf) ) ==0x50 ) || ( ( s[0] & (~0x7) ) ==0x10 ) ){
this should be replaced by a simple 2 bit check as arpi said

+                       float tmp=sh->fps;
                        sh->fps = stream_read_word(demuxer->stream);
+                       if (sh->fps<=0) sh->fps=tmp; 
                        sh->frametime = 1.0f/sh->fps;
why not
                       int fps2= stream_read_word(demuxer->stream);
                       if (fps2>0) sh->fps= fps2; 
                       sh->frametime = 1.0f/sh->fps;

[...]

Michael