[MPlayer-dev-eng] [PATCH] decoding of MS-RLE in 4-bit is buggy

[Roberto Togni]

On 2003.06.29 18:59 Michael Günnewig wrote:
> MichaelGuennewig at gmx.de (Michael Günnewig) writes:
> 
> > Roberto Togni <r_togni at libero.it> writes:
> >
> >> On 2003.06.13 20:13 Michael Günnewig wrote:
> >>> Hallo.
> >>> The decoding of Microsoft-RLE in 4-bit doesn't work correctly
> under
> >>> all circumstances. As described at
> >>>   http://www.pcisys.net/~melanson/codecs/msrle.txt
> >>> must the code be aligned at a word-boundary when in absolute mode.
> 
>  ...
> 
[...]
> 
> Okay, now I have the results. The above code works with the previous
> test-video, but not with some other test-videos. I also found out that
> the previous test-video was bad, but I couldn't find out why I was
> possible to decode it correctly under windows -- think I have changed
> it
> by mistacke with anotherone.
> 
> The correct code must be
> 
>    rle_code   = ((stream_byte + 1) & (~1)) / 2;
>    extra_byte = rle_code & 0x01;
> 
> which is the same as the spec says.
> 
I'll apply it. Can you please upload a working sample (i don't have any 
4bit MSrle files)?

> 
>   Michael Günnewig
> 
Ciao,
  Roberto