[MPlayer-dev-eng] Re: [PATCH] Real Audio/Video DLL support for Mac OS X

[Diego Biurrun]

Donnie Smith writes:
 > Should output such as "Don't forget to copy pncrt.Shlb to the Codecs dir!"
 > be output when the configure script is run, or should it simply result
 > in the error (when running mplayer) I mentioned in my last mail, and
 > letting the user solve it by reading the docs (which I will update
 > once the questions in my previous mail are answered).

I vote for the error message plus the explanation in the docs.

 > I also found out the cause of the libiconv problems:
 > libvo/font_load_ft.c uses iconv without checking HAVE_ICONV,
 > guess font_load_ft.c's maintainer should fix the code... I'll check
 > why the configure script fails to detect my iconv (I have it installed).

Why don't you send in another patch? ;-)

Diego