[MPlayer-dev-eng] [PATCH#2] make the mplayer binary several 100k smaller

Michael Niedermayer michaelni at gmx.at
Mon Jun 23 11:28:00 CEST 2003


Hi

On Monday 23 June 2003 08:04, Andreas Hess wrote:
> On Thu, Jun 19, 2003 at 05:02:25PM +0200, Michael Niedermayer wrote:
> > hmm, i dont like the #ifdef CONFIG_ENCODERS patch, theres no point in
> > putting #ifdef CONFIG_ENCODERS #endif around static functions, a sane
> > compiler should not inlude them in the binary if they arent used
>
> The problems were, that some statics are still included, even so they
upgrade to gcc 3.4 :)

until then i dont see the advantage to put #ifdefs around every static 
fucntion just because of 3 or so functions which gcc includes incorrectly 
unless it breaks compilation

> are not referenced by other code, and that there were some references
> to encoding functions, because of a missing #ifdef CONFIG_ENCODERS.
yes, i think i fixed these in cvs

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en



More information about the MPlayer-dev-eng mailing list