[MPlayer-dev-eng] [PATCH] configure srcipt failed with --enable-gif

[D Richard Felker III]

On Fri, Jun 20, 2003 at 01:23:20AM +0200, Laczay Balint wrote:
> Hi Rich!
> 
> Maybe, I don't understand you exactly, just partially.
> 
> > The standard behavior for mplayer configure is that "yes" and "auto"
> > should not be the same. "yes" should force a feature on even if it
> > can't be detected. So if you want to fix this problem, the correct
> > way to do it is to fix the version detect (bug workaround) stuff so
> > it doesn't fail if gif libs aren't detected...
> 
> First let us make it clear, that in the current state, if you have a
> _properly_installed_ gif library, and give --enable-gif, then configure
> fails (misdetects version and bug-workaround), and building even fails
> because of a missing library on linking.  This is wrong for sure.
> 
> Anyway, I see your point.  But I don't know how to force "on" a gif
> library setting even if it is not found.  The problem is that you
> need a "-l..." switch for linking, and this _must_ be autodetected!
> (Or we should create a new configure option e.g. --with-gif-library,
> but I don't think, that it would be the right way...)
> 
> Or we can set a default, if library autodetection does not work.  Maybe
> this is the best solution, which follows the guideline you have given.
> But than what should be the default for the -l switch?  There are four
> possiblities in the configure file, choosen by autodetection.
> 
> 	_ld_gif="-lungif"
> 	_ld_gif="-lungif $_ld_x11"
> 	_ld_gif="-lgif"
> 	_ld_gif="-lgif $_ld_x11"
> 
> Anyway, I don't know anything about the details, so I cannot settle
> a default...  (Where I can test it (Debian 3.0), all four works, since
> libgif is just a symlink to libungif, and X is not needed there.)
> 
> I'm not sending this email to the list.  I think this is so boring for
> the others.  If I'm making this wrong, please tell me, I'm still a newbie.
> Oh, and sorry for that missing -u, here is the unified patch.  Next time
> should I cut the first four lines and start only from "^diff.*", or not?

Please keep mplayer mail on the list!! We have a list for a reason!

OK, so I see what the problem is. Maybe if we just wait a few weeks,
the whole detection nonsense will be a non-issue? Unisys patent
expires very soon now so hopefully people will stop using this stupid
libungif...

If you do want to fix it now, I suppose you're right -- force-yes is
not a valid option for gif right now... :/

Rich