[MPlayer-dev-eng] [PATCH] configure srcipt failed with --enable-gif

[D Richard Felker III]

On Thu, Jun 19, 2003 at 06:40:47PM +0200, Laczay Balint wrote:
> Hi!
> 
> In short: The configure script failed to generate valid config, if
> --enable-gif was given.  (Since autodetection works fine, the problem
> is not serious, just annoying.)  Problem is fixed by this patch.
> 
> Problem details: The configure script should determine automagically which
> libraries are needed to lib_gif.h functions to work (libgif/libungif,
> and possibly x11).  But only does this if the "$_gif" variable is set to
> "auto", which is the default.  Certainly, if you set "$_gif" to "no"
> with --disable-gif, the configure script works well, and disables gif
> support.  But if you set it to "yes" with --enable-gif, then the script
> will enable the support (and later tries to check for the giflib version
> and for a needed bug-workaround).  But it simply _will_not_determine_
> which libs to use, and will not use any library at all (nor along the
> configuration, neither along the build).  This causes errors at linking.
> (Moreover, the libgif version and bug-workaround detection also fails,
> since the missing libraries.  (Moreover, since the script passes an
> empty argument as the library to cc_check, the gcc will try to compile
> file named "", and certainly fails.  Maybe this should be considered as
> a bug in the generic cc_check code.))
> 
> Solution: The patched version checks for the libs both "$_gif" = "auto"
> and "$_gif" = "yes" cases.  If the libs are not found, then will turn off
> support if "$_gif" was auto, and will report an error if "$_gif" was yes.
> 
> Comment: Sorry, I'm a newbie, this is my first patch, maybe not perfect
> (and I know that is is also very superfuous :).


The standard behavior for mplayer configure is that "yes" and "auto"
should not be the same. "yes" should force a feature on even if it
can't be detected. So if you want to fix this problem, the correct way
to do it is to fix the version detect (bug workaround) stuff so it
doesn't fail if gif libs aren't detected...

Also, send patches as unified diff. :)

Rich