[MPlayer-dev-eng] [PATCH] configure srcipt failed with --enable-gif

[Laczay Balint]

Hi!

In short: The configure script failed to generate valid config, if
--enable-gif was given.  (Since autodetection works fine, the problem
is not serious, just annoying.)  Problem is fixed by this patch.

Problem details: The configure script should determine automagically which
libraries are needed to lib_gif.h functions to work (libgif/libungif,
and possibly x11).  But only does this if the "$_gif" variable is set to
"auto", which is the default.  Certainly, if you set "$_gif" to "no"
with --disable-gif, the configure script works well, and disables gif
support.  But if you set it to "yes" with --enable-gif, then the script
will enable the support (and later tries to check for the giflib version
and for a needed bug-workaround).  But it simply _will_not_determine_
which libs to use, and will not use any library at all (nor along the
configuration, neither along the build).  This causes errors at linking.
(Moreover, the libgif version and bug-workaround detection also fails,
since the missing libraries.  (Moreover, since the script passes an
empty argument as the library to cc_check, the gcc will try to compile
file named "", and certainly fails.  Maybe this should be considered as
a bug in the generic cc_check code.))

Solution: The patched version checks for the libs both "$_gif" = "auto"
and "$_gif" = "yes" cases.  If the libs are not found, then will turn off
support if "$_gif" was auto, and will report an error if "$_gif" was yes.

Comment: Sorry, I'm a newbie, this is my first patch, maybe not perfect
(and I know that is is also very superfuous :).

Regards,
Balint

-- 
    Laczay Balint
www.szit.bme.hu/~blac
   blac at szit.bme.hu
-------------- next part --------------
Index: configure
===================================================================
RCS file: /cvsroot/mplayer/main/configure,v
retrieving revision 1.728
diff -r1.728 configure
3166,3167c3166
< if test "$_gif" = auto ; then
<   _gif=no
---
> if test "$_gif" = auto || test "$_gif" = yes ; then
3185a3185,3189
>   else
>     if test "$_gif" = yes ; then
>       die "GIF library was not found"
>     fi
>     _gif=no
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030619/1fede22a/attachment.pgp>