[MPlayer-dev-eng] [BUG] cool! stringkezeles again => [PATCH]

Pierre Lombard p_l at gmx.fr
Tue Jun 17 01:33:23 CEST 2003


* gabucino at mplayerhq.hu <gabucino at mplayerhq.hu> [2003-06-13 08:05]:
> mplayer dvd://1 -chapter	->	SIG11 (what else..)
> 
> MPlayer dev-CVS-030612-00:29-2.95.3 (C) 2000-2003 Árpád Gereöffy (see DOCS)
> 
> CPU: Advanced Micro Devices Athlon TB Thunderbird (Family: 6, Stepping: 2)
> Detected cache-line size is 64 bytes
> CPUflags:  MMX: 1 MMX2: 1 3DNow: 1 3DNow2: 1 SSE: 0 SSE2: 0
> Compiled with Runtime CPU Detection - WARNING - this is not optimal!
> To get best performance, recompile MPlayer with --disable-runtime-cpudetection
> Reading config file /etc/mplayer/mplayer.conf
> Reading config file /root/.mplayer/config
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 1024 (LWP 10494)]
> 0x8176d54 in dvd_parse_chapter_range ()
> (gdb) bt
> #0  0x8176d54 in dvd_parse_chapter_range ()
> #1  0x8546850 in ?? ()
> #2  0x808cb2d in m_config_set_option ()
> #3  0x8546d70 in ?? ()

Patch attached.

Same fix as in: libmpcodecs/vf_pp.c:int readPPOpt(void *, char *)

-- 
Best regards,
 Pierre
-------------- next part --------------
Index: libmpdemux/open.c
===================================================================
RCS file: /cvsroot/mplayer/main/libmpdemux/open.c,v
retrieving revision 1.81
diff -u -r1.81 open.c
--- libmpdemux/open.c	17 May 2003 12:24:01 -0000	1.81
+++ libmpdemux/open.c	16 Jun 2003 23:28:58 -0000
@@ -552,6 +552,8 @@
   const char *s;
   char *t;
 /*  conf; prevent warning from GCC */
+  if (range == NULL)
+    return -2; // ERR_MISSING_PARAM
   s = range;
   dvd_chapter = 1;
   dvd_last_chapter = 0;


More information about the MPlayer-dev-eng mailing list