[MPlayer-dev-eng] [PATCH] Autoconfiguration for XML DOCS building system
Diego Biurrun
diego at biurrun.de
Sun Jun 15 00:36:10 CEST 2003
On Sat, Jun 14, 2003 at 05:16:10PM -0500, Zoltan Hidvegi wrote:
> > Dmitry Baryshkov writes:
> > You use things like
> >
> > if test "x$_catalog" != "x"
> > if test "x$_chunk_xsl" = "x"
> >
> > which is OK, but
> >
> > if test -n "$_catalog"
> > if test -z "$_chunk_xsl"
> >
> > or if you prefer
> >
> > if [ -n "$_catalog" ]
> > if [ -z "$_chunk_xsl" ]
> >
> > are simpler IMHO. The creation of html.xsl etc are also simplified
>
> Some old shells do not handle test -n "$foo" well if foo is some
> binary operator, e.g. if foo is =, it will expand to test -n =, and
> some shells think that you want to compate -n to =. This cannot
> happen in a POSIX shell, where the semantics of test is well-defined,
> but some unixes still have the old bourne shell which is buggy.
> Writing "x$foo" always works on all shells.
OK, now I see what this was good for, but the main configure is full of test
-n and test -z anyway, so I guess we do not need to support such broken
shells.
Hmm, another thought.. Should we put this into the main configure instead?
Diego
More information about the MPlayer-dev-eng
mailing list