[MPlayer-dev-eng] Re: [PATCH] theora update #2

[David Kuehling]

>> just updated ogg demuxer and theora decoder for the changes in the
>> libtheora API which caused compilation to fail.

> -// theora_comment tc; + theora_comment tc;

> if you do such changes, you should also add theora version check in
> ./configure.  this makes code uncompilable for ppl having older
> libtheora installed (like me).

> the best would be do #ifdef VERSION>1234 type thing in the code, so it
> could work with any version

sorry, i thought that would not be that important, as theora is still
very alpha.  it don't expect it to have useful version information yet,
but could make configure check for all the features required for
compilation, using the cc_check.  BTW the current README of libtheora
states that it should *NOT* yet be used for implementing mplayer/xine
plugins :-)

>> if you're annoyed by frequent updates, tell me and I'll try to
>> accumulate more changes before posting them here.

> iu can give you cvs write access, if you change your behaviour of
> breaking teh code :)

i promise :-)

David
-- 
GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg
Fingerprint: B17A DC95 D293 657B 4205  D016 7DEF 5323 C174 7D40