[MPlayer-dev-eng] [PATCH] Mac OS X updates for darwinfixlib, libmpeg2 and ao_macosx

[D Richard Felker III]

On Tue, Jun 10, 2003 at 12:59:09AM +0200, Dan Christiansen wrote:
> Hi,
> 
> Attached are three patches for MPlayer :)
> 
> mplayer-makefile.diff:
> 
> I've found it rather annoying that MPlayer would run ranlib on all 
> libraries even though only one of them where changed. It meant that 
> mplayer and mencoder would be relinked when running "make install" - 
> very annoying indeed. This patch will change the behaviour from running 
> ranlib on all libraries prior to linking to processing libraries one at 
> a time after their compilation.

If this really happens, it should be fixed, but it never happens to
me. Nothing should have changed when you run make install...

> mplayer_ao.diff:
> 
> I figured out what the issue was with the resampling of movies, etc; I 
> was simply setting ao_data.outburst incorrectly. I guess I shouldn't 
> have blamed the resampler so quickly ;) I tested it with various 
> sampling rates, mono and stereo, and all seem to work well. Unless 
> there are more bugs, I believe this is good enough to replace make 
> ao_sdl obsolete on Mac OS X. Other than that the patch contains volume 
> control and some cleanups.

Didn't we already go over the fact that volume emulation through
software does NOT belong in ao drivers?? Use pl_volume for the time
being (-aop list=volume) or fix mplayer to be able to control
af_volume interactively. But don't add ugly hacks like this.

Rich