arpi at thot.banki.hu
Sun Jun 8 23:52:47 CEST 2003
> Is my TiVo patch going to be included into the release?
dunno, i'm not mplayer-g1 maintainer since a while...
but after a quick look on your patch
i see several problems:
- it is not optional, ie after applying the patch all the changes are
enabled for all users on all platforms. it wouldn't be problem, but the code
contains not portable elements too, at first look. also some embedded
systems user doesn't want to include such big useless (for them) code...
- you did some unexplained changes in steram layer, like pos=>newpos change
in streaming code, incrementing stream buffer size from 2k to 128k and so on
they may cause problems in other stream drivers/demuxers.
- you imported a big code in the mstream/ directory, and compile it
unconditionaly. is it compilable on all supported playforms? is it really
required to be imported (isn't available as dynamic library, ie does it
contain mpalyer-specific changes?)
- patch contains several cosmetics changes, but it doens't really matter
(just note to patch commiter, to remove them first)
the patch is basicly well written (i mean integrating to mplayer api/layers)
but has some parts which needs to be fixed or explained/discussed before can
A'rpi / Astral & ESP-team
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu
More information about the MPlayer-dev-eng