[MPlayer-dev-eng] [PATCH] decoder and encoder support for DivX 5.0.5 API

[Arpi]

Hi,

> I've found some time to implement the encoding support for the new
> DivX API. Now it's possible to play and encode movies with the
> latest DivX release.
> One thing that doesn't work is the new Video Buffer Verifier (VBV)
> multipass encoding. The encoder segfaults. Maybe it just isn't
> supported with the standard profile of the released binary encoder.

nice work, thanks!

i've commited with 2 small changes:

ve_divx4 added param "mpeg2" for old divx, but it doesn't have (at least my
5.0.2), removed. and it renamed param psychovisual to pv, it is somewhat ok,
nut is against our cvs policy point 4:

4. Do not change behavior of the program (renaming options etc) without
   discussing it first at the mplayer-dev-eng mailing list. Do not remove
   functionality from the code. Just improve!
   Do not commit changes to the build system (Makefiles, configure script)
   which change behaviour, defaults etc, without asking (and your change being
   accepted) on the mplayer-dev-eng mailing list first. 

such change requires changing users' mind and the documentation :)
(decide which takes longer :))


the other part was in vd_odivx.c, moving get_image call up and using
mpi->width. it's incorrect when IMGTYPE_EXPORT is used, because it means all
params (including stride, width) is provided by the codec (so codec=>mpi and
not mpi=>codec). i've changed it to sh->disp_w.

(it would be inetersting to use stride hints from next filter/vo, but it's
not implemenetd in mplayer-g1 architecture).


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu