[MPlayer-dev-eng] [PATCH] Volume control for ao_macosx

[Dan Christiansen]

Attached is a patch to add support for volume control to ao_macosx. A 
patch largely similar to this one was rejected, but I ask you to 
reconsider it.

It was rejected on the grounds that I had reused some code from the 
volume control plugin. The amount of code reused is in the order of a 
few lines (where I removed everything not strictly necessary), and 
since I use the lowest possible layers in CoreAudio, the only way of 
having it control volume would be to set the system wide volume, and 
that's not an option.

Please apply this patch, I believe it's the only proper way to add 
volume control to ao_macosx (in it's current incarnation) that doesn't 
require a large amount of changes to the MPlayer core. If it were to be 
handled by CoreAudio, it would require a total rewrite of the output 
module to use higher level APIs - I plan to do that some time - but 
until then, this is a fair compromise.

- Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ao-mac.diff
Type: application/octet-stream
Size: 4437 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030606/9e5e43d9/attachment.obj>