[MPlayer-dev-eng] main: [BUG?] draw_slice in vd_libmpeg2.c and [PATCH] some warning fixes

[Michael Niedermayer]

Hi

On Sunday 01 June 2003 21:00, Dominik Mierzejewski wrote:
[...]
> vf_scale.c:35: warning: excess elements in struct initializer
> vf_scale.c:35: warning: (near initialization for `vf_priv_dflt')
> -> as above
ok

>
> vf_scale.c:322: warning: deprecated use of label at end of compound
> statement -> missing "break;"
ok

>
> Also I think it's a good idea to remove duplicate definitions of
> get_sws_cpuflags() from Gui/wm/ws.c and libmpcodecs/vf_scale.c and put it
> in postproc/swscale.[ch] so that it can be automatically visible in
> vf_sab.c and vf_smartblur.c where it's used (and gives "implicit
> declaration" warnings now).
no, bad, the cpudetect code is not part of the swscaler, so get_sws_cpuflags() 
must not be in postproc/swscale* it would break compiation of the swscale 
code without the mplayer cpudetect code
perhaps, simply adding vf_scale.h would be a solution

[...]
>
> rgb2rgb.h:123: warning: implicit declaration of function `printf'
> -> missing #include <stdio.h> in rgb2rgb.c
hmm, IMHO either remove yuv2rgb* its useless anyway, or move it to rgb2rgb.c, 
but printf() in a header with #include <stdio.h> in the c file is hmm not so 
good

> vo_x11.c:400: warning: implicit declaration of function
> `sws_getContextFromCmdLine'
> vo_x11.c:400: warning: assignment makes pointer from integer without a cast
> vo_x11.c:484: warning: assignment makes pointer from integer without a cast
> vo_vesa.c:805: warning: implicit declaration of function 
> `sws_getContextFromCmdLine'
> vo_vesa.c:805: warning: assignment makes pointer from integer without a cast
> -> missing sws_getContextFromCmdLine declaration (it's in vf_scale)
ok but i think it would be cleaner if this is put into vf_scale.h too

> vo_dga.c:328: warning: implicit declaration of function `rgb15to16'
> -> missing #include "../postproc/rgb2rgb.h"
ok

> vo_dga.c:687: warning: implicit declaration of function `SwScale_Init'
> -> could as well be removed, because it doesn't do anything according to
>    postproc/swscale.c
ok

[...]
> swscale.c:1707: warning: implicit declaration of function
> `sws_rgb2rgb_init' mga_common.c:428: warning: implicit declaration of
> function `sws_rgb2rgb_init' wm/ws.c:327: warning: implicit declaration of
> function `sws_rgb2rgb_init' -> missing declaration in rgb2rgb.h, added
ok

ill apply the ok cases

-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en