[MPlayer-dev-eng] Re: Mplayer unable to play MPEG2-TS over RTP (Was: Mplayer as a Client for VideoLAN server)

[Ross Finlayson]

>>So, what I've done instead is updated the LIVE.COM interface code (in the 
>>latest CVS) to add a new function:
>>         int demux_is_multiplexed_rtp_stream(demuxer_t* demuxer)
>>
>>This function will tell you whether or not a RTP demuxer will contain 
>>multiplexed (i.e., interleaved) audio+video.  If you decide to add 
>>special-case code  - e.g., to "demuxer.c" - to handle interleaved 
>>streams, you can use this function, after calling "demux_open_rtp()", to 
>>tell you whether or not to execute this special-case code.
>>
>>         Ross.
>
>why not calling demux_open_stream() from within demux_rtp.cpp ?
>demuxer.c is already a mess, and IMO needs  a serious clean-up, not more 
>code that can be put in each demuxer ( where imo  it belongs ).

No, whatever code is required to turn an interleaved stream (on a single 
"demuxer_t") into separate audio+video streams (on separate "demuxer_t"s) 
is something that should be done outside "demux_rtp.cpp", because it has 
nothing to do with the LIVE.COM code, or RTP in general.  It's something 
that's specific to MPlayer's general demuxer implementation, which is where 
it belongs.  (I merely provide a hook - the new 
"demux_is_multiplexed_rtp()" function - that will tell you - for RTP 
streams - when you need to do this.)

I agree that "demuxer.c" is a mess, and needs cleaning up, but not by just 
moving the mess into other pieces of the code where it doesn't belong :-)

         Ross.