[MPlayer-dev-eng] Re: [PATCH] (hopefully) better dumpvideo

[Nico]

so the previous patch should already be fine, since it's just after the 
following section

if((stream_dump_type)&&(stream_dump_type<4)){
  FILE *f;
  demux_stream_t *ds=NULL;
  current_module="dump";
  // select stream to dump
  switch(stream_dump_type){
  case 1: ds=d_audio;break;
  case 2: ds=d_video;break;
  case 3: ds=d_dvdsub;break;


right?

Arpi wrote:

>Hi,
>
>  
>
>>Nico writes:
>> > attached is the patch to mplayer.1 (I hope it's correct, mc shows it 
>> > correctly, but I don't know that strange formatting language).
>> > 
>> > Watch: the real patch hasn't been committed yet.
>> > 
>> > Hope to have gained some good karma :)
>>
>>I would suggest you post a new, complete version of your patch, this
>>will be easier to review and commit then.
>>
>>I suggest you rename the -rawdump option to -dumprawvideo to be more
>>consistent with the other -dump options.
>>    
>>
>
>imho it should be a flag-type option, called -dumpraw or so, and it
>should affect both -dumpaudio, -dumpvideo and -dumpsub behaviour.
>(it's useful to include packet size in audio too, for some formats,
>like vorbis or qdm2)
>
>
>A'rpi / Astral & ESP-team
>
>--
>Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu
>
>_______________________________________________
>MPlayer-dev-eng mailing list
>MPlayer-dev-eng at mplayerhq.hu
>http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>
>  
>