[MPlayer-dev-eng] [PATCH]s - tidying of pause message
Diego Biurrun
diego at biurrun.de
Mon Jul 14 19:06:35 CEST 2003
Diego Biurrun writes:
> Alex Sisson writes:
> > --- Diego Biurrun <diego at biurrun.de> wrote: > Alex
> > Sisson writes:
> > > > These patches (one for each help/*.h) make the
> > > pause
> > > > message not go on the next line and all a
> > > standard
> > > > format of === $WORD_FOR_PAUSE ===.
> > >
> > > OK, does not sound bad, but in help_mp-en.h, it is
> > > defined as follows:
> > >
> > > #define MSGTR_Paused "\n================= PAUSED
> > > =================\r"
> > >
> > > So I think the it should be more than three '='
> > > signs on each side of
> > > $WORD_FOR_PAUSE. Could you redo your patch
> > > following this suggestion?
> > > I will gladly apply it then.
> >
> > I made it shorter, because when playing audio files
> > the stats are shorter, so the pause line has to be
> > shorter other wise you get unerased ==== at the eol.
> > i guess i could probably add a few more but not as
> > many as currently.
>
> You have a point here. It does definitely look better this way when
> playing audio files. What about this:
>
> ===== PAUSED =====
>
> Other languages just should not use more than 23 characters, since the
> status line is 23 characters long with audio files.
Committed, with a newline in front so status messages remain readable.
Diego
More information about the MPlayer-dev-eng
mailing list