[MPlayer-dev-eng] [PATCH][BUG] GUI shows black when X depth is 16/15 bpp

Arpi arpi at thot.banki.hu
Sat Jul 12 19:19:54 CEST 2003


Hi,

> I attach a fix to the problem described in:
> http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-July/019494.html
> The bug came out to be that sws_rgb2rgb_init was called, but only after
> the critical step in which ws.c copied the relevant function pointer to
> wsConvFunc. Someone deserves 1000l for this.
> Maybe we want to preinit the function pointers so that they will print
> something like "Call to an rgb2rgb function without calling to
> sws_rgb2rgb_init first. Please report." - this bug wasn't discovered since
> the function pointers were NULL, and the rest of the cde uses "wsConvFunc"
> only if it is not NULL.
> 
> Cheers
> Shachar

huh, nice work!
commited.

Is it 0_90 material? :) (C)Diego


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list